fix: add outputformat to API call for SavedQuery#1121
Merged
SjurSutterudSagen merged 1 commit intomainfrom Feb 2, 2026
Conversation
This fixes a situation where a SavedQuery fails to load data in TableView, because it's outputformat was not Json-stat2. We now ask for Json-stat2 specifically when fetching the SQ data, since this is the only format PxWeb2 understands. We should also add these kinds of fixes to the remaining API calls, but that is outside this PR. I will create a task for that, so people can have a different default in the PxWeb2Api than Json-stat2.
Branch Deployment to Cloudflare Pages🚛 Preview URL: https://84fd5a7d.pxweb2.pages.dev |
|
SjurSutterudSagen
changed the title
SjurSutterudSagen
requested review from
KentMossback,
MikaelNordberg,
PerIngeVaaje,
likp,
michaelpande,
oyessb and
runejo
as code owners
SjurSutterudSagen
deleted the
fix/improve-savedquery-handling-by-specifically-asking-for-supported-response-format
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a situation where a SavedQuery fails to load data in TableView, because it's outputformat was not Json-stat2. We now ask for Json-stat2 specifically when fetching the SQ data, since this is the only format PxWeb2 understands.