Skip to content

Fix: Wrap functions in variablesprovider with use callback#1128

Merged
SjurSutterudSagen merged 2 commits intomainfrom
fix/wrap-functions-in-variablesprovider-with-useCallback
Feb 12, 2026
Merged

Fix: Wrap functions in variablesprovider with use callback#1128
SjurSutterudSagen merged 2 commits intomainfrom
fix/wrap-functions-in-variablesprovider-with-useCallback

Conversation

@SjurSutterudSagen
Copy link
Copy Markdown
Contributor

@SjurSutterudSagen SjurSutterudSagen commented Feb 9, 2026

This fixes a number of linter warnings, and we should consider refactoring the functions out of the provider and into a utility function later.

Also used GPT 5.2 to generate some tests for the VariablesProvider, since it didn't have any.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 9, 2026

Branch Deployment to Cloudflare Pages

🚛 Preview URL: https://42893705.pxweb2.pages.dev
🚧 Branch preview URL: https://fix-wrap-functions-in-variab.pxweb2.pages.dev
🚚 Alternative Preview URL: https://7e1452fc.pxweb2.pages.dev
👷 Alternative Branch preview URL: https://alternative-fix-wrap-functio.pxweb2.pages.dev

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 9, 2026

@SjurSutterudSagen SjurSutterudSagen marked this pull request as ready for review February 9, 2026 13:59
@SjurSutterudSagen SjurSutterudSagen changed the title Fix/wrap functions in variablesprovider with use callback Fix: Wrap functions in variablesprovider with use callback Feb 12, 2026
Copy link
Copy Markdown
Contributor

@MikaelNordberg MikaelNordberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@SjurSutterudSagen SjurSutterudSagen merged commit 43c1583 into main Feb 12, 2026
14 checks passed
@SjurSutterudSagen SjurSutterudSagen deleted the fix/wrap-functions-in-variablesprovider-with-useCallback branch February 12, 2026 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants