Skip to content

Add packageManager field to package.json#1305

Merged
SjurSutterudSagen merged 1 commit into
mainfrom
fix/add-packageManager-field-to-packagejson
Jun 5, 2026
Merged

Add packageManager field to package.json#1305
SjurSutterudSagen merged 1 commit into
mainfrom
fix/add-packageManager-field-to-packagejson

Conversation

@SjurSutterudSagen
Copy link
Copy Markdown
Contributor

@SjurSutterudSagen SjurSutterudSagen commented Jun 4, 2026

This adds a packageManager field with a set npm version to the package.json file, in an attempt to make the dependabot updates use that version.

The reason for this is that we are seeing some unrelated changes in the dependabot updates, that we suspect are because it resolves to an older npm version (11.8.0). Setting the npm version to the one that comes packaged with the newest node lts version (11.13.0).

Running "npm audit fix" with node v24.16.0 and npm v11.13.0 gives no changes.
Running "npx npm@11.8.0 audit fix" removes alot of libc fields, like we are seeing.

This adds a packageManager field with a set npm version to the
package.json file, in an attempt to make the dependabot updates use that
version.

The reason for this is that we are seeing some unrelated changes in the
dependabot updates, that we suspect are because it resolves to an older
npm version (11.8.0). Setting the npm version to the  one that comes
packaged with the newest node lts version (11.13.0).
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

Branch Deployment to Cloudflare Pages

🚛 Preview URL: https://a9dc0f43.pxweb2.pages.dev
🚧 Branch preview URL: https://fix-add-packagemanager-field.pxweb2.pages.dev
🚚 Alternative Preview URL: https://fa1452ed.pxweb2.pages.dev
👷 Alternative Branch preview URL: https://alternative-fix-add-packagem.pxweb2.pages.dev

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 4, 2026

@SjurSutterudSagen
Copy link
Copy Markdown
Contributor Author

SjurSutterudSagen commented Jun 4, 2026

Looked at what npm resolves to in this run: https://github.com/PxTools/PxWeb2/actions/runs/26944087721/job/79492569321

Dependabot PR with the current problem: https://github.com/PxTools/PxWeb2/pull/1298/changes

Copy link
Copy Markdown
Contributor

@MikaelNordberg MikaelNordberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@SjurSutterudSagen SjurSutterudSagen merged commit e9bd3af into main Jun 5, 2026
13 checks passed
@SjurSutterudSagen SjurSutterudSagen deleted the fix/add-packageManager-field-to-packagejson branch June 5, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants