Change when NavDrawer is open by default#767
Merged
SjurSutterudSagen merged 1 commit intomainfrom Aug 15, 2025
Merged
Conversation
This changes when the NavDrawer is opened by default on initial table page load. Since we found issues with focus being hidden behind it, it was decided that a better solution for keyboard users is to not start in a state where focus can be hidden. Now only shows it by default on larger than the large breakpoint. Considered adding a simpler check in TableViewer, but decided to expand the solution for checking window width in the AppProvider. To be consistent with previous solutions.
Branch Deployment to Cloudflare Pages🚛 Preview URL: https://2588c5d0.pxweb2.pages.dev |
|
SjurSutterudSagen
requested review from
KentMossback,
MikaelNordberg,
PerIngeVaaje,
likp,
michaelpande,
oyessb and
runejo
as code owners
ssb-cgn
approved these changes
Aug 15, 2025
SjurSutterudSagen
deleted the
feature/PxWeb2-715-change-nav-drawer-open-by-default-breakpoints
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes when the NavDrawer is opened by default on initial table page load. Since we found issues with focus being hidden behind it, it was decided that a better solution for keyboard users is to not start in a state where focus can be hidden. Now only shows it by default on larger than the large breakpoint.
Considered adding a simpler check in TableViewer, but decided to expand the solution for checking window width in the AppProvider. To be consistent with previous solutions.