Add support for translations in Storybook/UI-lib#768
Merged
SjurSutterudSagen merged 2 commits intomainfrom Aug 15, 2025
Merged
Conversation
This adds a first iteration of language support to the Storybook in the PxWeb2 UI library. The solution was made following Storybooks example for this, but I also made considerations for speed and reducing complexity. Therefore, there are improvements that can be made to this. For instance, we could consider moving the translation into their own package, and import them into other packages as needed. Now it just imports directly from the web app.
Branch Deployment to Cloudflare Pages🚛 Preview URL: https://b3c69c89.pxweb2.pages.dev |
|
SjurSutterudSagen
requested review from
KentMossback,
MikaelNordberg,
PerIngeVaaje,
likp,
michaelpande,
oyessb and
runejo
as code owners
SjurSutterudSagen
deleted the
feature/PxWeb2-685-add-language-support-to-storybook-instance
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a first iteration of language support to the Storybook in the PxWeb2 UI library. The solution was made following Storybooks example for this, but I also made considerations for speed and reducing complexity.
Therefore, there are improvements that can be made to this. For instance, we could consider moving the translation into their own package, and import them into other packages as needed. Now it just imports directly from the web app.
It also adds some stories to the VariableBox component, since we had left those out because they used the translations in such a large degree. The chevron for the groupings is determined by the input, so it does not switch when the language switches in the Storybook. Therefore I added a story for RTLdirection, which shows it being the correct way for RTL.