Add first value when changing codelist for mandvar#773
Merged
SjurSutterudSagen merged 1 commit intomainfrom Aug 15, 2025
Merged
Conversation
This adds the logic for adding default values, when changing codelists for mandatory variables. The values chosen is limited to the first value, but the code should be easily extendable to be expanded later. This is why I chose to have the logic for adding the defaults seperated from adding codelist to variables. Any extra processing should not have a significant impact, since we are only mapping over variables here, and not values. Also updated the tests.
Branch Deployment to Cloudflare Pages🚛 Preview URL: https://04e7dc86.pxweb2.pages.dev |
|
SjurSutterudSagen
requested review from
KentMossback,
MikaelNordberg,
PerIngeVaaje,
likp,
michaelpande,
oyessb and
runejo
as code owners
SjurSutterudSagen
deleted the
feature/PxWeb2-740-choose-default-value-when-changing-codelist-mand-var
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the logic for adding default values, when changing codelists for mandatory variables. The values chosen is limited to the first value, but the code should be easily extendable to be expanded later. This is why I chose to have the logic for adding the defaults seperated from adding codelist to variables. Any extra processing should not have a significant impact, since we are only mapping over variables here, and not values.
Also updated the tests.