Change the PivotButton to have proper design#802
Merged
SjurSutterudSagen merged 8 commits intomainfrom Aug 22, 2025
Merged
Conversation
This changes the PivotButton to have the correct design and aria functionality. Refactored the ActionItem slightly, so it can have different label and aria-label.
Branch Deployment to Cloudflare Pages🚛 Preview URL: https://e9e6d2de.pxweb2.pages.dev |
This expands the PivotButton component in DrawerEdit, so it gives two different texts to screen readers to read. The first one if the text of the button, when it is focused. The second texts is the new, order of the variables, like they currently are shown in the title of the table.
Add so the PivotButton has 3 texts from translations. 1. The button text that is shown 2. The aria-label text that screen readers read on focusing the button 3. The screen reader announcement that is read after pivoting
Fix missing labels in the DrawerSave component, due to the ActionItem implementation having changed. Also expanded tests for the save to file functionality of the DrawerSave component, since there were no tests for that, only other functionality inside the DrawerSave component. Used GPT-5 (preview) in CoPilot to help and generate much of this. However, decided to not implement some tests for more flakey implementations, like the "more than 5 seconds" announcement.
|
SjurSutterudSagen
requested review from
KentMossback,
MikaelNordberg,
PerIngeVaaje,
likp,
michaelpande,
oyessb and
runejo
as code owners
SjurSutterudSagen
deleted the
PxWeb2-763-change-pivot-button-to-correct-looks
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the PivotButton to have the correct design and aria functionality. Refactored the ActionItem slightly, so it can have different label and aria-label.