Skip to content

Changed variable.css so that it references other css variables #880

Merged
likp merged 2 commits intomainfrom
fix/css-variables
Sep 19, 2025
Merged

Changed variable.css so that it references other css variables #880
likp merged 2 commits intomainfrom
fix/css-variables

Conversation

@likp
Copy link
Contributor

@likp likp commented Sep 16, 2025

Changed outputReferences = true option to CSS variable files so that it generates css variable references instead of the actual value.

@github-actions
Copy link

github-actions bot commented Sep 16, 2025

Branch Deployment to Cloudflare Pages

🚛 Preview URL: https://02baf649.pxweb2.pages.dev
🚧 Branch preview URL: https://fix-css-variables.pxweb2.pages.dev

@runejo
Copy link
Member

runejo commented Sep 17, 2025

@likp should we include the changed variables.css? I see its on the .gitignore list

@likp
Copy link
Contributor Author

likp commented Sep 17, 2025

@runejo I am uncertain my self. We generate the variables.css and we do it twice. Once in pxweb2-ui and and one in the pxweb2 under public/theme. I see that we have a ignore rule for theme/variables.css but since the theme folder is not directly in the root the variables.css in pxweb2 is not ignored. The other variables.css in pxweb2-ui is ignored since it is place in the dist folder which has it´s on ignore rule.

My guess is that they are ignored since they are automatically generated so that we might as well ignore them. If so we should fix the ignore rule to be **/theme/variables.css.

@runejo
Copy link
Member

runejo commented Sep 18, 2025

@runejo I am uncertain my self. We generate the variables.css and we do it twice. Once in pxweb2-ui and and one in the pxweb2 under public/theme. I see that we have a ignore rule for theme/variables.css but since the theme folder is not directly in the root the variables.css in pxweb2 is not ignored. The other variables.css in pxweb2-ui is ignored since it is place in the dist folder which has it´s on ignore rule.

My guess is that they are ignored since they are automatically generated so that we might as well ignore them. If so we should fix the ignore rule to be **/theme/variables.css.

This PR would be faster to review if it was not ignorede. The main branch has an up to date theme/variable.css, maybe this is whats making it confusing.

PerIngeVaaje
PerIngeVaaje previously approved these changes Sep 18, 2025
Copy link
Contributor

@PerIngeVaaje PerIngeVaaje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@likp
Copy link
Contributor Author

likp commented Sep 18, 2025

@runejo I am uncertain my self. We generate the variables.css and we do it twice. Once in pxweb2-ui and and one in the pxweb2 under public/theme. I see that we have a ignore rule for theme/variables.css but since the theme folder is not directly in the root the variables.css in pxweb2 is not ignored. The other variables.css in pxweb2-ui is ignored since it is place in the dist folder which has it´s on ignore rule.
My guess is that they are ignored since they are automatically generated so that we might as well ignore them. If so we should fix the ignore rule to be **/theme/variables.css.

This PR would be faster to review if it was not ignorede. The main branch has an up to date theme/variable.css, maybe this is whats making it confusing.

Oh, I see. I add the the updated variables.css file.

@sonarqubecloud
Copy link

@likp likp requested a review from PerIngeVaaje September 18, 2025 08:06
@likp likp merged commit eac86da into main Sep 19, 2025
15 checks passed
@likp likp deleted the fix/css-variables branch September 19, 2025 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants