Make Disposition an IntFlag so Stream.disposition setter accepts members#2257
Open
HotariTobu wants to merge 1 commit intoPyAV-Org:mainfrom
Open
Make Disposition an IntFlag so Stream.disposition setter accepts members#2257HotariTobu wants to merge 1 commit intoPyAV-Org:mainfrom
HotariTobu wants to merge 1 commit intoPyAV-Org:mainfrom
Conversation
Stream.disposition is typed as Disposition but the runtime setter assigns to a C int field, calling int(value). Plain Flag members are not int subclasses, so this raises TypeError. IntFlag members are int subclasses; bitwise / membership semantics are preserved. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2256
Stream.dispositionis typed asDispositionbut the runtime setter (self.ptr.disposition = value, a Cintfield) callsint(value), which fails on plainFlagmembers because they are notintsubclasses. SwitchingDispositiontoIntFlagfixes the contract: members areintsubclasses, so the conversion succeeds, and bitwise / membership semantics are unchanged.Both
av/stream.py(runtime) andav/stream.pyi(stub) are updated for consistency.