Conversation
The remux examples skipped demux's flushing packet with `packet.dts is None`. That assumption is wrong: a valid keyframe can demux with no DTS (e.g. the leading reordered packets of a B-frame stream in a PTS-only container like MKV). For such files the keyframe was dropped, producing an undecodable video that only played the audio. Skip the empty flushing packet with `packet.size == 0` instead, and apply the same fix to the remux loops in the test suite. Adds a regression test that encodes a B-frame MKV (whose first packet is a keyframe with no DTS) and asserts the remux keeps it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.