Residual Flux Fraction#74
Merged
Merged
Conversation
Jammy2211
requested review from
Sketos,
caoxiaoyue,
qiuhan96,
rhayes777 and
samlange04
Jammy2211
pushed a commit
that referenced
this pull request
May 1, 2026
… mode) NumPy >=1.26 raises "object __array__ method not producing an array" when __array__ returns a non-np.ndarray. Our impl returned self._array directly, but _array can be a jax.Array on the JAX path (e.g. set by `_array = jnp.where(...)` in __setitem__). Coerce to numpy via np.asarray to satisfy the protocol contract. Also added the `copy` kwarg introduced in numpy 2.0; without it, future numpy may pass copy positionally and break the call. Surfaced by python_matrix.yml smoke runs on autogalaxy_workspace, which hit `np.array(vis.slim)` in autoarray/plot/utils.py:plot_visibilities_1d on every Python version. Issue #74 in PyAutoBuild Category A. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows one to compute and plot the residual flux fraction [(data - model)/data] for an imaging fit.