Skip to content

feature/fits interface#69

Merged
Jammy2211 merged 13 commits intomainfrom
feature/fits_interface
Apr 2, 2025
Merged

feature/fits interface#69
Jammy2211 merged 13 commits intomainfrom
feature/fits_interface

Conversation

@Jammy2211
Copy link
Copy Markdown
Collaborator

Refactors the majority of astropy.fits.io functionality into a single module, fitsable.py in PyAutoConf.

This is used in other projects to unify .fits interfaces and separates all functionality into a single module.

PyAutoFit still interfaces with astropy directly in places like the aggregator, as it uses single-line python astropy interfaces that are clearer written as they currently are.

@Jammy2211 Jammy2211 requested a review from rhayes777 March 24, 2025 19:34
@Jammy2211 Jammy2211 changed the title Feature/fits interface feature/fits interface Mar 24, 2025
Copy link
Copy Markdown
Collaborator

@rhayes777 rhayes777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems odd to me to put this in conf. Would it not make more sense in galaxy or array?

Copy link
Copy Markdown
Collaborator

@rhayes777 rhayes777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think given that galaxy inherits from autoarray and fits are really arrays this code should live in there?

@Jammy2211
Copy link
Copy Markdown
Collaborator Author

PyAutoFit also handles .fits files, and whilst not much of this refactor made it into autofit it felt like it ultimately would, was why I put it here.

@rhayes777
Copy link
Copy Markdown
Collaborator

PyAutoFit also handles .fits files, and whilst not much of this refactor made it into autofit it felt like it ultimately would, was why I put it here.

Ah yeah of course

@rhayes777
Copy link
Copy Markdown
Collaborator

PyAutoFit also handles .fits files, and whilst not much of this refactor made it into autofit it felt like it ultimately would, was why I put it here.

Ah yeah of course

It's a bit weird that AutoFit supports it natively but it would be quite a pain to decouple

@Jammy2211 Jammy2211 merged commit e92d537 into main Apr 2, 2025
8 checks passed
@Jammy2211 Jammy2211 deleted the feature/fits_interface branch April 30, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants