Conversation
This reverts commit 16b1185.
Jammy2211
left a comment
There was a problem hiding this comment.
I would maybe suggest AggregateCSV rather than AggregateSummary as the latter seems generic, assuming that we'll also have an AggregatePNG soon too.
Unless you think the API you've chosen makes more sense for some reason? I
|
Yeah makes sense |
|
I began writing an example script using this for PyAutoGalaxy. First, I wrote my own However, the The API for how a user customizes the png splicing makes a lot of sense: But the Is it feasible to make it so This would mean that |
|
I was thinking about this the other day and maybe the way to handle it is to have a mapping in each place the enum is used? Something like class Subplot(Enum):
Data = 1
SignalToNoiseMap = 2
...
position_map = {
Subplot.Data: (0, 0),
SignalToNoiseMap: (1, 0),
...
}Alternatively we could bake everything in to the enum values. You can even use class instances to provide the values giving a bit more structure and flexibility. |
Introduces a summary CSV over chosen fields from search output using the aggregator as per #1087
Does not currently support numerical errors as the current output is not sufficient and changing the output results in failing tests.
Usage: