Conversation
Jammy2211
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous inversion API called the errors in a mesh source reconstruction as the property
errors, which were defined as the variance in each mesh pixel.This was confusing, as the
errorswere defined differently from thenoise_mapused throughout the code in dataset objects, and the errors required anp.sqrtto become the RMS standard deviation values like thenoise_map.This PR renames the inversion
errorsto thereconstruction_noise_mapand includes thenp.sqrtsuch that they are RMS standard deviations consistent with dataset objects.