Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request primarily removes references to the
InterpolatedReconstructionplotting class from the codebase, simplifying the plotting API and cleaning up unused imports and arguments.Source Science Examples:
Specific examples showing how to perform the source science calculations which previously used
MapperValued, but now just use scipy directly, are available on the autolens workspace:https://github.com/Jammy2211/autolens_workspace/blob/main/notebooks/imaging/source_science.ipynb
https://github.com/Jammy2211/autolens_workspace/blob/main/notebooks/imaging/features/pixelization/source_science.ipynb
Plotting API cleanup:
InterpolatedReconstructionargument from theMatPlot2Dclass constructor and its internal usage inautogalaxy/plot/mat_plot/two_d.py. [1] [2]InterpolatedReconstructionfrom theautogalaxy/plot/__init__.pyfile.General code cleanup:
MapperValuedfromautogalaxy/__init__.py.