Skip to content

Updated critical curve and caustic functions#92

Merged
Jammy2211 merged 13 commits intoPyAutoLabs:mainfrom
kassidy-kollmann:feature/critical-curves
Mar 18, 2023
Merged

Updated critical curve and caustic functions#92
Jammy2211 merged 13 commits intoPyAutoLabs:mainfrom
kassidy-kollmann:feature/critical-curves

Conversation

@kassidy-kollmann
Copy link
Copy Markdown
Collaborator

I made changes to the following functions in autogalaxy/operate/deflections.py:

  • tangential_critical_curve_from and radial_critical_curve_from: I updated these two functions so that they now return all tangential (and radial) critical curves for the lensing system, as opposed to returning only one curve even when multiple exist. With these changes, the critical_curves_from function still returns a list with two entries, however, now each entry is its own list containing all tangential critical curves (for the first entry) and all radial critical curves (for the second entry).
  • tangential_caustic_from and radial_caustic_from: These functions now return all tangential (and radial) caustics. The caustics_from function now returns a list with two entries, where the first entry is a list of all tangential caustics and the second entry is a list of all radial caustics.
  • area_within_tangential_critical_curve_from, einstein_radius_from, einstein_mass_angular_from: Since there may be multiple tangential critical curves for a lensing system, these functions now return lists where each entry corresponds to one tangential critical curve.

@Jammy2211
Copy link
Copy Markdown
Collaborator

I have made the following updates and will now merge to main:

  • Updated the API of deflections.py to explicitly name functions to return a list (e.g. tangential_critical_curve_list_from.
  • Removed all instances where tangential and radial critical curves / caustics are merged into one (e.g. in the plotting functions), such that one can separately customize them. This includes removing critical_curves_from / caustics_from.

Thank you!

@Jammy2211 Jammy2211 marked this pull request as ready for review March 18, 2023 16:28
@Jammy2211 Jammy2211 merged commit 475880b into PyAutoLabs:main Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants