Skip to content

Rewrap point fit data + magnifications for JAX backend parity #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jammy2211 merged 1 commit into from
Apr 18, 2026
Merged

Rewrap point fit data + magnifications for JAX backend parity #442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions autolens/point/fit/abstract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ def __init__(
"""

self.name = name
if xp is not np and data._xp is not xp:
data = aa.Grid2DIrregular(values=data.array, xp=xp)
self._data = data
self._noise_map = noise_map
self.tracer = tracer
Expand Down Expand Up @@ -131,9 +133,12 @@ def magnifications_at_positions(self) -> aa.ArrayIrregular:
use_multi_plane=use_multi_plane,
plane_j=plane_j,
)
return abs(
od.magnification_2d_via_hessian_from(grid=self.positions, xp=self._xp)
magnifications = od.magnification_2d_via_hessian_from(
grid=self.positions, xp=self._xp
)
if self.use_jax:
magnifications = aa.ArrayIrregular(values=magnifications)
return abs(magnifications)

@property
def source_plane_coordinate(self) -> Tuple[float, float]:
Expand Down
Loading