Skip to content

fix: drop AdaptImages single-pixelated-galaxy fallback in lens.to_inversion #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jammy2211 merged 1 commit into from
Apr 26, 2026
Merged

fix: drop AdaptImages single-pixelated-galaxy fallback in lens.to_inversion #474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion autolens/imaging/model/analysis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,9 @@ def fit_from(

dataset_model = self.dataset_model_via_instance_from(instance=instance)

adapt_images = self.adapt_images_via_instance_from(instance=instance)
adapt_images = self.adapt_images_via_instance_from(
instance=instance, galaxies=tracer.galaxies
)

return FitImaging(
dataset=self.dataset,
Expand Down
4 changes: 3 additions & 1 deletion autolens/interferometer/model/analysis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,9 @@ def fit_from(self, instance: af.ModelInstance) -> FitInterferometer:
instance=instance,
)

adapt_images = self.adapt_images_via_instance_from(instance=instance)
adapt_images = self.adapt_images_via_instance_from(
instance=instance, galaxies=tracer.galaxies
)

return FitInterferometer(
dataset=self.dataset,
Expand Down
23 changes: 6 additions & 17 deletions autolens/lens/to_inversion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,24 +270,12 @@ def adapt_galaxy_image_pg_list(self) -> List[List[np.ndarray]]:
)

for galaxy in galaxies_with_pixelization_list:
try:
image = self.adapt_images.galaxy_image_dict[galaxy]
except (AttributeError, KeyError, TypeError):
if self.adapt_images is None:
image = None

# Bug fix whereby for certain models the galaxy doesnt pair correctly.

if image is None and len(galaxies_with_pixelization_list) == 1:
galaxy_list = self.adapt_images.galaxy_image_dict.keys()
galaxy_with_pixelization = [
galaxy
for galaxy in galaxy_list
if galaxy.has(cls=aa.Pixelization)
][0]

image = self.adapt_images.galaxy_image_dict[
galaxy_with_pixelization
]
else:
image = self.adapt_images.image_for_galaxy(
galaxy, self.tracer.galaxies
)

plane_image_list.append(image)

Expand Down Expand Up @@ -330,6 +318,7 @@ def image_plane_mesh_grid_pg_list(self) -> List[List]:
adapt_images=self.adapt_images,
settings=self.settings,
xp=self._xp,
path_galaxies=self.tracer.galaxies,
)

image_plane_mesh_grid_list = to_inversion.image_plane_mesh_grid_list
Expand Down
Loading