Skip to content

fix: re-mirror likelihood scripts and datasets from clean origin/main of _developer#3

Merged
Jammy2211 merged 1 commit into
mainfrom
feature/jit-regression-drift
May 16, 2026
Merged

fix: re-mirror likelihood scripts and datasets from clean origin/main of _developer#3
Jammy2211 merged 1 commit into
mainfrom
feature/jit-regression-drift

Conversation

@Jammy2211
Copy link
Copy Markdown
Contributor

Summary

Phase 1 (#1, merged via PR #2) copied the source-of-truth scripts and datasets from the local canonical checkout of autolens_workspace_developer, which had ~36 modified files and a non-empty dirty staging area at the time. As a result the merged mirror carried in-progress modifications instead of the published origin/main state.

Surfaced by the autolens_profiling F1 triage (autolens_workspace_developer#67): when smoking the same scripts against clean origin/main of _developer, imaging/mge.py PASSED its regression assertion (27379.388907), but the mirrored copy was reporting 27542.08 — a 0.6% drift that turned out to be from copying the canonical's locally-modified dataset/imaging/hst/*.fits, not an upstream drift.

This PR re-mirrors scripts + datasets from a fresh feature/jit-regression-drift worktree based on clean origin/main and re-applies the same Phase 1 path rewrites verbatim.

What changed

  • 9 likelihood scripts refreshed (−470 / +294 net): reverts in-progress _developer modifications that should not have been part of the Phase 1 mirror.
  • dataset/imaging/hst/{data,noise_map}.fits restored to clean-main bytes (canonical's locally-modified versions were displacing the published values).
  • dataset/imaging/hst/tracer.json restored to clean-main JSON.
  • dataset/interferometer/hannah/ added (5 files, 828K) — was tracked on clean main of _developer but missed by Phase 1's cp from the canonical (which lacked it locally for whatever reason).

Path rewrites reapplied unchanged:

  • Path(\"jax_profiling\") / \"dataset\"Path(\"dataset\")
  • _script_dir.parents[2]_script_dir.parents[1]
  • \"jax_profiling\" / \"results\" / \"jit\"\"results\" / \"likelihood\"
  • Docstring sibling-script and dataset refs rewritten to the new layout.
  • if al.util.dataset.should_simulate(...) subprocess block → clean FileNotFoundError pointing at autolens_workspace_developer/jax_profiling/dataset_setup/.

Verification

Test plan

  • python likelihood/imaging/mge.py PASSES regression (27379.388907 matches constant).
  • (Expected to remain failing) python likelihood/point_source/image_plane.py — load-bearing while PyAutoLens#514 is open.
  • (Expected to remain failing) python likelihood/point_source/source_plane.py — load-bearing while PyAutoLens#514 is open.
  • (Expected to remain failing) python likelihood/imaging/pixelization.py — load-bearing while autolens_workspace_developer#68 is open.
  • (Expected to remain failing) python likelihood/imaging/delaunay.py — load-bearing while autolens_workspace_developer#69 is open.

Refs PyAutoLabs/autolens_workspace_developer#67

🤖 Generated with Claude Code

… of _developer

Phase 1 (#1, PR #2) copied the source-of-truth scripts and datasets from
the local canonical checkout of autolens_workspace_developer, which had
~36 modified files and a non-empty dirty staging area at copy time. As a
result the merged mirror carried in-progress modifications instead of
the published origin/main state, which showed up as:

- imaging/mge.py log-likelihood drifted +0.6% (27542.08 vs 27379.39).
  Caused by mirrored copy of locally-modified dataset/imaging/hst/*.fits.
- datacube/delaunay.py default instrument was "sma" in the mirror but
  is "hannah" on clean origin/main of _developer.
- Several scripts carried in-progress refactors of the cube / inversion
  pipelines unrelated to the Phase 1 mirror goal.

This commit re-mirrors from /home/jammy/Code/PyAutoLabs-wt/jit-regression-drift/autolens_workspace_developer
(a fresh worktree on clean origin/main) and re-applies the same Phase 1
path rewrites:

- Path("jax_profiling") / "dataset" -> Path("dataset")
- _script_dir.parents[2] -> _script_dir.parents[1]
- "jax_profiling" / "results" / "jit" -> "results" / "likelihood"
- docstring sibling refs rewritten to new layout
- if should_simulate(...) subprocess block -> clean FileNotFoundError

Changes vs Phase 1:

- 9 likelihood scripts refreshed (-470/+294 lines net; reverts
  in-progress _developer modifications that should not have been in
  the mirror).
- dataset/imaging/hst/{data,noise_map}.fits restored to clean-main
  bytes; dataset/imaging/hst/tracer.json restored to clean-main JSON.
- dataset/interferometer/hannah/ added (5 files, 828K) — was tracked
  on clean main of _developer but missed by Phase 1's copy.

Verification: re-running likelihood/imaging/mge.py with the refreshed
mirror produces log_likelihood = 27379.388907, exactly matching
EXPECTED_LOG_LIKELIHOOD_HST. The +0.6% drift reported in PR #2's
test plan is fully resolved.

Surfaced by F1 (#67 on autolens_workspace_developer) — the F1 smoke on
clean _developer main passed for imaging/mge, which contradicted the
mirror smoke and led to discovering the dirty-canonical copy. The
remaining F1 drifts (point_source) are real upstream behaviour changes
and are tracked separately under #67.

Refs PyAutoLabs/autolens_workspace_developer#67

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant