fix: re-mirror likelihood scripts and datasets from clean origin/main of _developer#3
Merged
Merged
Conversation
… of _developer Phase 1 (#1, PR #2) copied the source-of-truth scripts and datasets from the local canonical checkout of autolens_workspace_developer, which had ~36 modified files and a non-empty dirty staging area at copy time. As a result the merged mirror carried in-progress modifications instead of the published origin/main state, which showed up as: - imaging/mge.py log-likelihood drifted +0.6% (27542.08 vs 27379.39). Caused by mirrored copy of locally-modified dataset/imaging/hst/*.fits. - datacube/delaunay.py default instrument was "sma" in the mirror but is "hannah" on clean origin/main of _developer. - Several scripts carried in-progress refactors of the cube / inversion pipelines unrelated to the Phase 1 mirror goal. This commit re-mirrors from /home/jammy/Code/PyAutoLabs-wt/jit-regression-drift/autolens_workspace_developer (a fresh worktree on clean origin/main) and re-applies the same Phase 1 path rewrites: - Path("jax_profiling") / "dataset" -> Path("dataset") - _script_dir.parents[2] -> _script_dir.parents[1] - "jax_profiling" / "results" / "jit" -> "results" / "likelihood" - docstring sibling refs rewritten to new layout - if should_simulate(...) subprocess block -> clean FileNotFoundError Changes vs Phase 1: - 9 likelihood scripts refreshed (-470/+294 lines net; reverts in-progress _developer modifications that should not have been in the mirror). - dataset/imaging/hst/{data,noise_map}.fits restored to clean-main bytes; dataset/imaging/hst/tracer.json restored to clean-main JSON. - dataset/interferometer/hannah/ added (5 files, 828K) — was tracked on clean main of _developer but missed by Phase 1's copy. Verification: re-running likelihood/imaging/mge.py with the refreshed mirror produces log_likelihood = 27379.388907, exactly matching EXPECTED_LOG_LIKELIHOOD_HST. The +0.6% drift reported in PR #2's test plan is fully resolved. Surfaced by F1 (#67 on autolens_workspace_developer) — the F1 smoke on clean _developer main passed for imaging/mge, which contradicted the mirror smoke and led to discovering the dirty-canonical copy. The remaining F1 drifts (point_source) are real upstream behaviour changes and are tracked separately under #67. Refs PyAutoLabs/autolens_workspace_developer#67 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 1 (#1, merged via PR #2) copied the source-of-truth scripts and datasets from the local canonical checkout of
autolens_workspace_developer, which had ~36 modified files and a non-empty dirty staging area at the time. As a result the merged mirror carried in-progress modifications instead of the publishedorigin/mainstate.Surfaced by the autolens_profiling F1 triage (autolens_workspace_developer#67): when smoking the same scripts against clean
origin/mainof_developer,imaging/mge.pyPASSED its regression assertion (27379.388907), but the mirrored copy was reporting 27542.08 — a 0.6% drift that turned out to be from copying the canonical's locally-modifieddataset/imaging/hst/*.fits, not an upstream drift.This PR re-mirrors scripts + datasets from a fresh
feature/jit-regression-driftworktree based on cleanorigin/mainand re-applies the same Phase 1 path rewrites verbatim.What changed
_developermodifications that should not have been part of the Phase 1 mirror.dataset/imaging/hst/{data,noise_map}.fitsrestored to clean-main bytes (canonical's locally-modified versions were displacing the published values).dataset/imaging/hst/tracer.jsonrestored to clean-main JSON.dataset/interferometer/hannah/added (5 files, 828K) — was tracked on clean main of_developerbut missed by Phase 1'scpfrom the canonical (which lacked it locally for whatever reason).Path rewrites reapplied unchanged:
Path(\"jax_profiling\") / \"dataset\"→Path(\"dataset\")_script_dir.parents[2]→_script_dir.parents[1]\"jax_profiling\" / \"results\" / \"jit\"→\"results\" / \"likelihood\"if al.util.dataset.should_simulate(...)subprocess block → cleanFileNotFoundErrorpointing atautolens_workspace_developer/jax_profiling/dataset_setup/.Verification
Re-smoked
likelihood/imaging/mge.pyagainst the refreshed mirror:The 0.6% drift reported in PR feat: Phase 1 — mirror JIT likelihood profiling scripts #2's test plan is fully resolved — it was always a Phase 1 hygiene issue, not a real upstream drift.
The remaining point_source script drifts noted in PR feat: Phase 1 — mirror JIT likelihood profiling scripts #2 are real upstream behaviour changes, not mirror artifacts. They are tracked separately:
These remain failing in this PR (load-bearing regression assertions) until #514 is resolved.
Two additional bugs uncovered by smoking all 10 jit scripts on clean main (independent of the mirror hygiene fixed here):
jit/imaging/pixelization.pyJIT vs eager mapping matrix shape mismatch.jit/imaging/delaunay.pylog_evidence rebuild returns -inf vs FitImaging's finite value.Test plan
python likelihood/imaging/mge.pyPASSES regression (27379.388907 matches constant).python likelihood/point_source/image_plane.py— load-bearing while PyAutoLens#514 is open.python likelihood/point_source/source_plane.py— load-bearing while PyAutoLens#514 is open.python likelihood/imaging/pixelization.py— load-bearing while autolens_workspace_developer#68 is open.python likelihood/imaging/delaunay.py— load-bearing while autolens_workspace_developer#69 is open.Refs PyAutoLabs/autolens_workspace_developer#67
🤖 Generated with Claude Code