Add Y037 code to check for possible usage of PEP 604 new syntax #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: oleg.hoefling <oleg.hoefling@gmail.com>
Signed-off-by: Oleg Hoefling <oleg.hoefling@gmail.com>
Collaborator
Author
|
This check now has only 27 hits in typeshed, so I'd now be in favour of merging it. I don't have a strong opinion about whether we should switch the check off in typeshed's flake8 config for now, or add 27 |
Collaborator
Author
Collaborator
|
Thanks, I'd prefer to turn the new code off in typeshed for now; we can just rely on check_new_syntax.py and code review in the meantime. |
AlexWaygood
added a commit
to python/typeshed
that referenced
this pull request
Apr 6, 2022
Collaborator
Author
|
AlexWaygood
added a commit
to python/typeshed
that referenced
this pull request
Apr 6, 2022
Collaborator
Author
|
Aand we have a green CI! |
Akuli
approved these changes
Apr 7, 2022
Collaborator
Author
|
Thanks for the PR @hoefling! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #45 (a continuation of @hoefling's PR #184, which I accidentally closed).