Fix misleading error message for E251#171
Merged
florentx merged 2 commits intoPyCQA:masterfrom Feb 26, 2013
Merged
Conversation
Member
|
👍 Alternatively, "There should be no spaces ..." |
Contributor
|
I agree, and the docs/intro.rst should be updated too. |
florentx
added a commit
that referenced
this pull request
Feb 26, 2013
Fix misleading error message for E251
Contributor
|
Thank you |
Member
|
🍰 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's my code snip:
And the pep8 report:
I was very confused when reading the message, I think it is misleading and better to change the "no" to "unexpected" in the message.
BTW do you think we should allow the spaces around the equal sign in above case that one parameter takes the whole line? I personally think that is more readable.