Skip to content

utf-8 BOM support#193

Merged
florentx merged 1 commit intoPyCQA:masterfrom
sporty:master
May 1, 2013
Merged

utf-8 BOM support#193
florentx merged 1 commit intoPyCQA:masterfrom
sporty:master

Conversation

@sporty
Copy link
Copy Markdown
Contributor

@sporty sporty commented Apr 29, 2013

hi MR. jcrocholl

I'm japanease developper. I can speak poor english.
I fix pep8.py. error in reading utf-8 bom python script file.

sometime, utf-8 text file specify byte order mark(BOM) at the begginings of file.
http://en.wikipedia.org/wiki/Unicode

before fix. this is utf-8 text file with BOM.

#/usr/bin/env python

pep8 say this error. becourse "#!" is not start at beggings of file.

1:4: E261 at least two spaces before inline comment

at the reading lines,check 3 byte of beggings of file. if it is BOM, remove it.

and add testsuite/utf-8-bom.py for tests.

regard.

@florentx
Copy link
Copy Markdown
Contributor

thanks. I can confirm the issue on Debian but not on OS X.

@sporty
Copy link
Copy Markdown
Contributor Author

sporty commented Apr 30, 2013

Thanks, I confirmed on OS X mountain lion, windows 7, and 8.

florentx added a commit that referenced this pull request May 1, 2013
@florentx florentx merged commit e65d581 into PyCQA:master May 1, 2013
@sporty
Copy link
Copy Markdown
Contributor Author

sporty commented May 1, 2013

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants