Merged
Conversation
from this version, potential error when using star operator are detected in the parser and no more at compile time.
Member
|
Maybe not the right place to discuss this, but shouldn't we also drop python 3.5 ? It has ceased to be supported since September 2020. |
Contributor
Yes, this was briefly discussed in another issue. I said I would tackle it but did not. I can probably look at it in a week or two, if nobody beats me to it. :) Anyway, we can discuss that in this specifically created new issue: #3965. |
PCManticore
approved these changes
Dec 29, 2020
Contributor
PCManticore
left a comment
There was a problem hiding this comment.
Other than relaxing the astroid version so the CI is green, this looks good to go.
1 similar comment
Contributor
|
Thanks for all the work here ♥ |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps
Description
This PR is an attempt to deal with
python 3.9. The functional tests that where failing are now successful thanks to pylint-dev/astroid#858. Thestar_needs_assignment_py35is, IMHO, useless forpython3.9, because potential problem with star operator is now detected in the new parser used by python3.9. (with previous version it was detected only at compile time).Related Issue
Closes #3895 #3876