ZipFS: improper unpacking of (XML) files

[zopyx]

I have this sample code what will read a ZIP file containing a valid sd.xml XML file:

import fs.opener

zf, _ = fs.opener.open('zip://sample.zip', writeable=False)
print zf.listdir(u".")
data = zf.open(u'sd.xml', 'rb').read()
print data

The screenshot shows that the closing tag <smashdocc is corrupted instead of <smashdoc>.

The second screenshot

shows that the sd.xml XML file is correct.

The related sample.zip can be found here: https://public.zopyx.com/sample.zip

[willmcgugan]

Possibly an out by one error. Will take a look.

[althonos]

I could reproduce the error, the last char is missing if the text is long enough. Possibly an error with the buffer thing, I'll try to come up with a fix.

EDIT: The underlying file object discards its buffer when the size that's being read is larger than zipfile.ZipExtFile.MIN_READ_SIZE, so for a large file the last byte will be missing since the buffer is then empty.

[willmcgugan]

Fixed in 2.0.17 Thanks to @althonos