Unquote query string parameters #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not required, but allows the use of special characters and not have to unquote in the fs implementation. For example, a JSON string.
althonos
approved these changes
May 4, 2018
Member
|
@geoffjukes any chance of a test for this? Just a trivial check to confirm the query is unquoted... |
Contributor
Author
|
I'm so sorry @willmcgugan - I didn't see this notification, then I was away. Do you still need/want the tests? |
Contributor
Author
|
I'm a total n00b at forking/pull requests etc. I had already nuked this fork, and created a new one for a different pull request. I've added a test to that request (#173) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not required, but allows the use of special characters and not have to unquote in the fs implementation. For example, a JSON string.