Support for Windows NT FTP servers#227
Merged
willmcgugan merged 2 commits intoPyFilesystem:masterfrom Nov 3, 2018
Merged
Conversation
Member
|
Looks great! Any chance of a unit test? |
Contributor
Author
|
Sure, I just added a unit test and fixed some of the CI warnings as well. But first, because of my |
Member
|
Thanks. I'm not sure why CI was reporting an error there. I'll look in to that. |
Contributor
Author
|
Thanks for merging! Just to clarify: The problem was, that the CI was NOT reporting an error here in the CI github hook. And last question: Do you will create a minor version bump for this update? Best Regards, Silvan |
Member
|
Yeah, I don't know why the CI error wasn't showing up. It certainly used to. Will do a minor update soon. Need to review some other fixes. |
Member
|
Fix is in v2.1.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had some problems trying to connect to a Windows NT FTP server. FTP LIST lines look totally different from the linux ones, therefore we needed another regex parser and decoder in the
_ftp_parse.pyfile. I tested it against this server and our requirements (list directories, create directories, create files) work fine. But let me know if this PR doesn't match your style or if I have to do something else/different. Best regards!Support for Windows NT lines
ftpfs.py:_read_dir():[ '11-02-18 02:00PM <DIR> asdf', '11-02-18 01:50PM <DIR> data', '11-01-18 01:41PM <DIR> doc', '11-02-18 02:12PM <DIR> images', '11-02-18 03:33PM 9276 logo.gif' ]