Skip to content

Added geturl() method#289

Merged
willmcgugan merged 1 commit intoPyFilesystem:masterfrom
zmej-serow:patch-1
Jun 2, 2019
Merged

Added geturl() method#289
willmcgugan merged 1 commit intoPyFilesystem:masterfrom
zmej-serow:patch-1

Conversation

@zmej-serow
Copy link
Copy Markdown
Contributor

@zmej-serow zmej-serow commented Jun 1, 2019

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

A new method to get URL for FTP resource.
For example,
ftp://127.0.0.1/foo
ftp://127.0.0.1/foo/bar

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.7%) to 98.924% when pulling c472c06 on zmej-serow:patch-1 into 9c92da1 on PyFilesystem:master.

2 similar comments
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.7%) to 98.924% when pulling c472c06 on zmej-serow:patch-1 into 9c92da1 on PyFilesystem:master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.7%) to 98.924% when pulling c472c06 on zmej-serow:patch-1 into 9c92da1 on PyFilesystem:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 1, 2019

Coverage Status

Coverage increased (+0.0003%) to 99.613% when pulling c472c06 on zmej-serow:patch-1 into 9c92da1 on PyFilesystem:master.

@willmcgugan willmcgugan merged commit 50a1942 into PyFilesystem:master Jun 2, 2019
@lurch
Copy link
Copy Markdown
Contributor

lurch commented Jun 7, 2019

Sorry for coming late to the party... should this method (or the self.ftp_url method) also take username (if not 'anonymous'), proxy (if not None) and password (if not '') into account?

@willmcgugan
Copy link
Copy Markdown
Member

Good point. @zmej-serow what do you think?

@zmej-serow
Copy link
Copy Markdown
Contributor Author

@lurch, nice idea!
Will definitely take a look tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants