Skip to content

Commit 1dd1cf9

Browse files
Remove pointless setters in GitReleaseAsset (#1527)
This is the only class that includes property setters for two of the attributes, which are untested, and even if they were used, would have no impact since there is no method to submit the changes back to GitHub. Drop them.
1 parent d4b6131 commit 1dd1cf9

File tree

2 files changed

+0
-20
lines changed

2 files changed

+0
-20
lines changed

github/GitReleaseAsset.py

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -60,14 +60,6 @@ def name(self):
6060
self._completeIfNotSet(self._name)
6161
return self._name.value
6262

63-
@name.setter
64-
def name(self, value):
65-
"""
66-
:type: string
67-
"""
68-
self._completeIfNotSet(self._name)
69-
self._name.value = value
70-
7163
@property
7264
def label(self):
7365
"""
@@ -76,14 +68,6 @@ def label(self):
7668
self._completeIfNotSet(self._label)
7769
return self._label.value
7870

79-
@label.setter
80-
def label(self, value):
81-
"""
82-
:type: string
83-
"""
84-
self._completeIfNotSet(self._label)
85-
self._label.value = value
86-
8771
@property
8872
def content_type(self):
8973
"""

github/GitReleaseAsset.pyi

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,8 @@ class GitReleaseAsset(CompletableGithubObject):
2121
def id(self) -> int: ...
2222
@property
2323
def label(self) -> str: ...
24-
@label.setter
25-
def label(self, value: str) -> None: ...
2624
@property
2725
def name(self) -> str: ...
28-
@name.setter
29-
def name(self, value: str) -> None: ...
3026
@property
3127
def size(self) -> int: ...
3228
@property

0 commit comments

Comments
 (0)