Skip to content

Commit 5aab6f5

Browse files
Tighten asserts for new Permission tests (#1893)
The recently merged code checking attributes on Permissions overeagerly used assertEqual for everything, switch to the more appropriate methods.
1 parent 7687961 commit 5aab6f5

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

tests/Permissions.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,13 @@ def setUp(self):
2929
self.userRepo = self.g.get_repo("PyGithub/PyGithub")
3030

3131
def testUserRepoPermissionAttributes(self):
32-
self.assertEqual(self.userRepo.permissions.admin, False)
32+
self.assertFalse(self.userRepo.permissions.admin)
3333
# Attribute is not present for users (only for teams)
34-
self.assertEqual(self.userRepo.permissions.maintain, None)
35-
self.assertEqual(self.userRepo.permissions.pull, True)
36-
self.assertEqual(self.userRepo.permissions.push, False)
34+
self.assertIs(self.userRepo.permissions.maintain, None)
35+
self.assertTrue(self.userRepo.permissions.pull)
36+
self.assertFalse(self.userRepo.permissions.push)
3737
# Attribute is not present for users (only for teams)
38-
self.assertEqual(self.userRepo.permissions.triage, None)
38+
self.assertIs(self.userRepo.permissions.triage, None)
3939

4040
def testUserRepoPermissionRepresentation(self):
4141
self.assertEqual(

0 commit comments

Comments
 (0)