STARPIPChannel.request_x_pos: send C0 RX via left_x_arm#1012
Merged
BioCam merged 1 commit intoPyLabRobot:v1b1from Apr 27, 2026
Merged
STARPIPChannel.request_x_pos: send C0 RX via left_x_arm#1012BioCam merged 1 commit intoPyLabRobot:v1b1from
STARPIPChannel.request_x_pos: send C0 RX via left_x_arm#1012BioCam merged 1 commit intoPyLabRobot:v1b1from
Conversation
…ding invalid C0 RA pn=
Draft
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STARPIPChannel.request_x_poswas sendingC0 RA pn=<channel>withfmt="ra#####"— three independent bugs that together made the method unable to return a real X-arm position.Problems
C0 RAreads non-volatile EEPROM constants (calibration values set during service); it doesn't query the live X-arm encoder. Live X position isC0 RX.pnis not a validC0 RAfield —RAaccepts onlyidandra=<param>.The firmware silently ignores
pn. Verified on hardware: with nora=,RAechoes the most-recently-queried EEPROM parameter (afterra=kgreturnskg328; afterra=kfreturnskf3682) — so the broken implementation would have leaked an arbitrary, order-dependent EEPROM constant rather than a position.fmt="ra#####"cannot parse any realC0 RAreply, since responses always lead with the queried parameter name (e.g.kg<value>), never literalra.Net effect:
ValueErroron every call.Fix
Delegate to the existing
STARXArm.request_position()(which sendsC0 RX— verified on hardware to return the live X-arm carriage X).All PIP channels share the (left) X-arm carriage, so the value is the same regardless of
self.index.Matches
PLR:main'srequest_x_pos_channel_nbehaviour.A
# TODOcomment at the call site flags that this assumes a single rigid X-arm — needs revisiting for half-arm and Fluid Motion STAR (issue #822).