-
Notifications
You must be signed in to change notification settings - Fork 147
Expose STARBackend._iswap_rotate_both_joints_in_increments for parallelised, smooth motion
#1016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rickwierenga
merged 15 commits into
PyLabRobot:main
from
BioCam:expose-rotate-both-joints
Apr 28, 2026
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
523e523
Add iSWAP per-drive predefined-position readers; reorganize into rota…
BioCam 7020466
Expose iSWAP per-drive bound + resolution constants; reference from o…
BioCam 8942b3f
Use enum-aligned keys + mm link lengths in iSWAP predefined-position …
BioCam 813d954
polish
BioCam 8cf3c38
address Copilot review
BioCam 0f884c2
separate iswap link-length accessors from predefined-position readers
BioCam eeda0ab
organise linkage request section
BioCam 2ee5de3
simplify linkage retrieval methods
BioCam 8a661bd
expose iswap_rotate_both_joints for parallel joint absolute moves
BioCam 4ee13c0
simplify arguments
BioCam 5097ed6
Merge remote-tracking branch 'origin/main' into expose-rotate-both-jo…
BioCam d8400c5
align error messages and joint notation on rotate_both_joints
BioCam 5edd53a
Update pylabrobot/liquid_handling/backends/hamilton/STAR_backend.py
BioCam 25c1d10
Merge branch 'main' into expose-rotate-both-joints
BioCam 910f550
rename _iswap_rotate_both_joints_in_increments → _iswap_rotate_increm…
rickwierenga File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new command-building logic (range checks + string formatting for
wa/ta/wv/etc.) isn’t covered by unit tests. The repo already usesSTAR_tests.pyto assert exact firmware command strings for iSWAP-related operations; please add a focused test that calls_iswap_rotate_both_joints_in_increments(via a command-catcher/mocked backend) and asserts the assembledR0PA...command, including sign/zero-padding and boundary conditions.