molecular devices plate readers #715
Conversation
|
also, very important, please update the list of supported machines! https://github.com/PyLabRobot/pylabrobot/blob/main/docs/user_guide/machines.md |
rickwierenga
force-pushed
the
main
branch
2 times, most recently
from
1675cd6 to
2b2f7f9
Compare
| Returns: | ||
| A list of dictionaries, one for each timepoint. Each dictionary has a key (0, 0) | ||
| and a value containing the data, temperature, and time. |
There was a problem hiding this comment.
some readers allow wavelength filtering for luminescence and some don't. should we use 0 as key or something else?
| Returns: | ||
| A list of dictionaries, one for each timepoint. Each dictionary has a key (wavelength, 0) | ||
| and a value containing the data, temperature, and time. |
There was a problem hiding this comment.
why not use the wavelength as the key directly?
There was a problem hiding this comment.
don't we want to have tuple as key for the sake of consistency among all read types?
There was a problem hiding this comment.
Indexing with ,0 is strange in the api. They are slightly different reads, I don't see why we would use the same format for all
|
ready to merge? |
|
we still have this problem: #715 (comment) right now if I merged this it would break all protocol using a plate reader, there needs to be a migration path |
|
is the change in the last commit (“format”) not enough?
…On Sat, Nov 8, 2025 at 20:44 Rick Wierenga ***@***.***> wrote:
*rickwierenga* left a comment (PyLabRobot/pylabrobot#715)
<#715 (comment)>
we still have this problem: #715 (comment)
<#715 (comment)>
right now if I merged this it would break all protocol using a plate
reader, there needs to be a migration path
—
Reply to this email directly, view it on GitHub
<#715 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BWQC2YVLV2NUZCKJUIDCD53333BEFAVCNFSM6AAAAACJKFKTLOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTKMBXGUZDGMJYGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
my bad 😬 |
2 participants
molecular devices spectramax plate readers: m5 and 384plus