support reading any subset of wells on cytation5 #718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickwierenga
changed the title
rickwierenga
force-pushed
the
non-rectangular-shapes-cytation-plate-reading
branch
from
794279d to
72b0f8b
Compare
rickwierenga
deleted the
non-rectangular-shapes-cytation-plate-reading
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in #717 I added the option to read parts of plates
for the cytation this was constrained to rectangles since that's all the firmware supports
in this pr we update that to allow any subset of wells
we will find the largest rectangles in the specified wells and read those. this is faster because the cytation can scan column by column or row by row
note: gen5.exe will only read a rectangle when the entire subset is a rectangle. when the shape is anything just a little more complex than a full rectangle, it will read every well one by one. so PLR is much faster. see "infographic" below: