Add agilent_96_wellplate_150uL_Vb #738
Merged
+124
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickwierenga
reviewed
Nov 3, 2025
rickwierenga
reviewed
Nov 3, 2025
Comment on lines
80
to
81
| "size_x": diameter, # from spec | ||
| "size_y": diameter, # from spec |
Contributor
Author
There was a problem hiding this comment.
I came to the conclusion that the old definition was simply wrong. There is no Ub of that type, only Vb, and the linked spec sheet, PLR dimensions, and part number match the Vb. don't think depreciation func is necessary for this correction.
fderop
commented
Nov 9, 2025
| return liquid_height | ||
|
|
||
|
|
||
| def calculate_liquid_height_container_1segment_round_vbottom( |
Contributor
Author
There was a problem hiding this comment.
hard to believe that there was no existing v-bottom well calculator?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.