add verbose as default jupyter notebooks#831
Merged
rickwierenga merged 4 commits intoPyLabRobot:mainfrom Jan 22, 2026
Merged
Conversation
The previous check only verified that get_ipython exists, which is true for any IPython session. Now properly checks for ZMQInteractiveShell which is specific to Jupyter notebooks/lab. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Wrap comparison in bool() to satisfy mypy's no-any-return check. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Member
|
thanks @tibisabau ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implemented automatic verbose logging for PyLabRobot when running in Jupyter notebook environments. Added a helper function
_is_running_in_jupyter()that detects if the code is executing within a Jupyter/IPython session by checking for theget_ipythonbuilt-in. Modified theconfigure()function to automatically enable verbose mode by callingverbose(True)when a Jupyter environment is detected. This enhancement improves the user experience by providing immediate feedback and logging output in interactive notebook environments without requiring manual configuration.Closes #794.
The code in this pull request was generated by GitHub Copilot with the Claude Sonnet 4.5 model.
Checklist if Applicable
make test(650 tests passed, 0 failures)make lint,make format-check,make format