-
Notifications
You must be signed in to change notification settings - Fork 129
Rename Hamilton tip functions to follow naming convention #840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Renames Hamilton tip creator functions from ambiguous names like `low_volume_tip_with_filter` to descriptive names matching the tip rack naming pattern (e.g., `hamilton_tip_10uL_filter`). Changes: - Rename 10 µL tips: low_volume_tip_* → hamilton_tip_10uL* - Rename 50 µL tips: fifty_ul_tip_* → hamilton_tip_50uL* - Rename 300 µL tips: standard_volume_tip_* → hamilton_tip_300uL* - Rename 1000 µL tips: high_volume_tip_* → hamilton_tip_1000uL* - Rename 4000 µL tips: four_ml_tip_* → hamilton_tip_4000uL* - Rename 5000 µL tips: five_ml_tip* → hamilton_tip_5000uL* - Add variant suffixes: _slim, _wide, _ultrawide for special tip types - Old functions deprecated with warnings pointing to new names - Update all tip rack definitions to use new function names Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Remove version numbers and Sphinx directive syntax from deprecation docstrings. Use simple one-line format: 'Deprecated. Use :func:...' Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR renames Hamilton tip creator functions to follow a consistent naming convention that matches the tip rack naming pattern. All functions are renamed from ambiguous names like low_volume_tip_with_filter to descriptive names like hamilton_tip_10uL_filter. The refactoring maintains full backward compatibility by keeping the old function names as deprecation wrappers.
Changes:
- Renamed 15 tip creator functions to follow the pattern
hamilton_tip_{volume}uL[_filter][_variant] - Added deprecation warnings to all old function names with clear migration paths
- Updated all internal tip rack definitions to use the new function names
- Improved documentation with catalog numbers and clearer descriptions
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pylabrobot/resources/hamilton/tip_creators.py | Converted old function implementations to deprecation wrappers, added new functions with consistent naming pattern following hamilton_tip_{volume}uL[_filter][_variant] convention |
| pylabrobot/resources/hamilton/tip_racks.py | Updated all imports and internal references from old function names to new function names |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| """ | ||
|
|
||
| def hamilton_tip_5000uL_filter(name: Optional[str] = None) -> HamiltonTip: | ||
| """Hamilton 5000 µL tip with filter (`tt25` in venus)""" |
Copilot
AI
Jan 26, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both hamilton_tip_5000uL and hamilton_tip_5000uL_filter reference the same Venus tip type (tt25). These should likely have different Venus tip type identifiers since one has a filter and one does not. Please verify the correct Venus tip types for these two functions.
| """Hamilton 5000 µL tip with filter (`tt25` in venus)""" | |
| """Hamilton 5000 µL tip with filter""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, but I have no idea where this is defined
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary
Renames Hamilton tip creator functions from ambiguous names like
low_volume_tip_with_filterto descriptive names that match the tip rack naming pattern (e.g.,hamilton_tip_10uL_filter). This creates consistency across the Hamilton resources API and makes tip functions easier to discover and understand.Changes
All Hamilton tip creator functions now follow the pattern:
hamilton_tip_{volume}uL[_filter][_variant]Renamed Functions
10 µL tips:
low_volume_tip_no_filter→hamilton_tip_10uLlow_volume_tip_with_filter→hamilton_tip_10uL_filter50 µL tips:
fifty_ul_tip_no_filter→hamilton_tip_50uLfifty_ul_tip_with_filter→hamilton_tip_50uL_filter300 µL tips:
standard_volume_tip_no_filter→hamilton_tip_300uLstandard_volume_tip_with_filter→hamilton_tip_300uL_filterslim_standard_volume_tip_with_filter→hamilton_tip_300uL_filter_slimultrawide_standard_volume_tip_with_filter→hamilton_tip_300uL_filter_ultrawide1000 µL tips:
high_volume_tip_no_filter→hamilton_tip_1000uLhigh_volume_tip_with_filter→hamilton_tip_1000uL_filterwide_high_volume_tip_with_filter→hamilton_tip_1000uL_filter_wideultrawide_high_volume_tip_with_filter→hamilton_tip_1000uL_filter_ultrawide4000 & 5000 µL tips:
four_ml_tip_with_filter→hamilton_tip_4000uL_filterfive_ml_tip→hamilton_tip_5000uLfive_ml_tip_with_filter→hamilton_tip_5000uL_filterBackward Compatibility
DeprecationWarningwith clear migration pathMigration Example
Test Plan
Benefits
hamilton_96_tiprack_10uL_filteruseshamilton_tip_10uL_filter)🤖 Generated with Claude Code