Skip to content

Remove context manager#763

Merged
methane merged 2 commits intoPyMySQL:masterfrom
methane:remove-context-manager
Dec 19, 2018
Merged

Remove context manager#763
methane merged 2 commits intoPyMySQL:masterfrom
methane:remove-context-manager

Conversation

@methane
Copy link
Copy Markdown
Member

@methane methane commented Dec 18, 2018

No description provided.

@methane methane merged commit e06bbac into PyMySQL:master Dec 19, 2018
@methane methane deleted the remove-context-manager branch December 19, 2018 08:45
@ulidtko
Copy link
Copy Markdown

ulidtko commented Apr 24, 2020

Woah, what an ample deprecation period! Whopping 7 weeks since #742.

(stops wondering why our PyMySQL 0.8.0 doesn't provide context manager for Connection)

@methane
Copy link
Copy Markdown
Member Author

methane commented Apr 25, 2020

PyMySQL 0.9.3 released at 2018-12-18.
So the deprecation period is more than 1 year.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants