expose Bound::as_gil_ref and Bound::into_gil_ref#3697
Merged
adamreichold merged 1 commit intoPyO3:mainfrom Dec 25, 2023
Merged
Conversation
CodSpeed Performance ReportMerging #3697 will not alter performanceComparing Summary
|
davidhewitt
force-pushed
the
as-gil-ref
branch
from
fc2a62e to
38abfd2
Compare
adamreichold
approved these changes
Dec 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes
Bound::as_gil_refandBound::into_gil_refas deprecated public APIs.As a general strategy for making the deprecation warnings manageable internally, for the blocks like
impl PyMappingwhich implements the GIL ref API forPyMapping, I've put#[allow(deprecated)]on the whole block. IMO I think this is better than marking#[allow(deprecated)]all uses inside those methods, but I can be persuaded otherwise.