Skip to content

Conversation

@alxhill
Copy link
Contributor

@alxhill alxhill commented Feb 11, 2024

The llvm-cov plugin needs to be installed as a cargo plugin (and at least on my system, had to run it manually once to respond to a user input prompt) before it works with nox.

nox -s coverage produces a coverage.json file and not lcov.info as of #3097, so also added an lcov option so nox -s coverage -- lcov returns the original format.

@alxhill alxhill changed the title docs: Clarify use of llmv-cov plugin docs: Clarify requirement for the llmv-cov plugin Feb 11, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 11, 2024

CodSpeed Performance Report

Merging #3825 will not alter performance

Comparing alxhill:patch-1 (f29770f) with main (f04ad56)

Summary

✅ 79 untouched benchmarks

@alxhill alxhill marked this pull request as draft February 11, 2024 18:27
@davidhewitt
Copy link
Member

Yes, indeed the coverage job in noxfile.py has been hard-coded to prepare the coverage for codecov, mostly just for lack of investment. If you're interested, we could improve it to interpret session.posargs to be able to generate different formats.

@alxhill
Copy link
Contributor Author

alxhill commented Feb 15, 2024

I'll give it a go later today - thanks for taking a look!

@alxhill alxhill marked this pull request as ready for review February 18, 2024 17:50
@alxhill alxhill changed the title docs: Clarify requirement for the llmv-cov plugin Add lcov / codecov options for nox codecov and update docs Feb 18, 2024
@alxhill alxhill changed the title Add lcov / codecov options for nox codecov and update docs Add lcov / codecov options for nox coverage and update docs Feb 18, 2024
@alxhill alxhill changed the title Add lcov / codecov options for nox coverage and update docs docs: Add lcov / codecov options for nox coverage and update docs Feb 18, 2024
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the help with tidying our docs, this looks good to me!

@davidhewitt davidhewitt added this pull request to the merge queue Feb 23, 2024
Merged via the queue into PyO3:main with commit 0f92b67 Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants