Skip to content

ci: re-enable list_get_item_unchecked benchmark on free-threaded build#5812

Merged
davidhewitt merged 1 commit intoPyO3:mainfrom
davidhewitt:get-item-unchecked-bench
Feb 14, 2026
Merged

ci: re-enable list_get_item_unchecked benchmark on free-threaded build#5812
davidhewitt merged 1 commit intoPyO3:mainfrom
davidhewitt:get-item-unchecked-bench

Conversation

@davidhewitt
Copy link
Member

This was disabled a long time ago because (IIRC) we didn't have get_item_unchecked enabled on the free-threaded build initially, once we had critical sections (I think) we re-enabled that function, but forgot the benchmark.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 13, 2026

Merging this PR will degrade performance by 15.87%

❌ 1 regressed benchmark
✅ 99 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
list_get_item_unchecked 3.3 ms 3.9 ms -15.87%

Comparing davidhewitt:get-item-unchecked-bench (f55065c) with main (a6c0fdd)

Open in CodSpeed

@davidhewitt davidhewitt added this pull request to the merge queue Feb 14, 2026
Merged via the queue into PyO3:main with commit c8ec67a Feb 14, 2026
44 of 45 checks passed
@davidhewitt davidhewitt deleted the get-item-unchecked-bench branch February 14, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants