Conversation
70f0bd1 to
b5efccb
Compare
bc46553 to
27af589
Compare
|
Thanks, the binary implementation looks fine to me (and matches what I've done locally in testing previously). Some thoughts / questions:
|
Good question. Building in this repository and publish on pypi is likely the easiest and nicest way to go. This way
No,
Definitely. Done. I have also added some documentation for the new maturin features. |
|
@davidhewitt just a small up to make sure you have seen my answers. Sorry for that |
Useful for setuptools-rust Use it also for the integration tests
27af589 to
4ee4fab
Compare
4ee4fab to
c697543
Compare
davidhewitt
left a comment
There was a problem hiding this comment.
Makes sense, I think we can indeed ship on PyPI with the same version numbering we use for the rest of PyO3?
|
(That can be a follow-up, I guess) |
26abbc6 to
de92476
Compare
Merging this PR will improve performance by 13.8%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | bench_pyclass_create |
4.6 µs | 4 µs | +13.8% |
Comparing Tpt:tpt/introspection-bin (9583119) with main (cf4d883)
Footnotes
-
1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩
de92476 to
2897f00
Compare
@davidhewitt Done. I have written the publishing action and setup a "pending publisher" on Pypi. When the next release is done I can share the package with you. |
Useful for setuptools-rust
Use it also for the integration tests