Use Py_GetConstantBorrowed for python True & False on abi3#5956
Merged
davidhewitt merged 1 commit intoPyO3:mainfrom Apr 8, 2026
Merged
Use Py_GetConstantBorrowed for python True & False on abi3#5956davidhewitt merged 1 commit intoPyO3:mainfrom
Py_GetConstantBorrowed for python True & False on abi3#5956davidhewitt merged 1 commit intoPyO3:mainfrom
Conversation
bschoenmaeckers
changed the title
True & False on abi3Py_GetConstantBorrowed for python True & False on abi3
bschoenmaeckers
force-pushed
the
get-constant-bool
branch
2 times, most recently
from
7759b2b to
7bcd209
Compare
bschoenmaeckers
force-pushed
the
get-constant-bool
branch
from
7bcd209 to
bfb6c7b
Compare
davidhewitt
approved these changes
Apr 8, 2026
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks 👍
I briefly considered whether we should do this on the version-specific API too, I think it's fine to keep accessing these symbols for now while they're in the CPython headers. (Note we define them static mut without pub so don't make the symbols accessible to users.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So we do not depend on
_Py_TrueStructwhen compiling forabi3xref RustPython/RustPython#7562