Draft
Conversation
ngoldbaum
commented
May 4, 2026
| self as *const Self as *const c_void, | ||
| other as *const Self as *const c_void, | ||
| std::mem::size_of::<Self>(), | ||
| ) == 0 |
Contributor
Author
There was a problem hiding this comment.
Should maybe check each field individually? I couldn't automatically derive this because of the unions.
| /// the function with a particular signature, and a mismatch is UB.) | ||
| #[macro_export] | ||
| #[cfg(Py_3_15)] | ||
| macro_rules! PySlot_FUNC { |
Contributor
Author
There was a problem hiding this comment.
It's also possible to do this with a sealed trait but that felt magical and complicated for a tiny bit of type safety that felt questionably useful to me, in practice. Please let me know if you'd prefer I not launder an unsafe transmute inside a macro like this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6012. Based on a version of CPython where I manually merged two open PRs. This is not mergeable until 3.15.0b1 actually releases to Github actions.
Adds support for the PEP 820 PySlot API, updates the PEP 793 implementation, and adds the critical section API to the limited API. Also fixes a small change to PyTypeObject that crept in since alpha8.
Claude helped a bit for code review and to figure out the
PySlot_FUNCand the__pyo3_pymodexportmacros.Ping @bschoenmaeckers because you asked in the issue what this would look like.