Skip to content

Introspection: adds backward compatibility tests#6019

Open
Tpt wants to merge 1 commit intoPyO3:mainfrom
Tpt:tpt/back-compat
Open

Introspection: adds backward compatibility tests#6019
Tpt wants to merge 1 commit intoPyO3:mainfrom
Tpt:tpt/back-compat

Conversation

@Tpt
Copy link
Copy Markdown
Contributor

@Tpt Tpt commented May 7, 2026

Introspect crates using old PyO3 versions and check if the output is still correct

Will be useful if we do breaking change to the introspection format

Introspect crates using old PyO3 versions and check if the output is still correct
@Tpt Tpt self-assigned this May 7, 2026
@Tpt Tpt added the CI-skip-changelog Skip checking changelog entry label May 7, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 7, 2026

Merging this PR will improve performance by 12.89%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 104 untouched benchmarks
⏩ 1 skipped benchmark1

Performance Changes

Benchmark BASE HEAD Efficiency
bench_pyclass_create 4.6 µs 4.1 µs +12.89%

Comparing Tpt:tpt/back-compat (f831993) with main (f57bda7)

Open in CodSpeed

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports.

Copy link
Copy Markdown
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, this makes a ton of sense to do. I wonder, how far do you expect we want to test backwards compatibility in this way?

@Tpt
Copy link
Copy Markdown
Contributor Author

Tpt commented May 9, 2026

I wonder, how far do you expect we want to test backwards compatibility in this way?

I see two possible interpretation of your question so I will try to answer both:

  • I would hope we can keep backward compatibility as much as possible i.e. be able to introspect builds with quite old versions of pyo3.
  • The current test is indeed currently quite basic. Expending it would be great. Topic for a follow up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-skip-changelog Skip checking changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants