Introspection: adds backward compatibility tests#6019
Conversation
Introspect crates using old PyO3 versions and check if the output is still correct
Merging this PR will improve performance by 12.89%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | bench_pyclass_create |
4.6 µs | 4.1 µs | +12.89% |
Comparing Tpt:tpt/back-compat (f831993) with main (f57bda7)
Footnotes
-
1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩
davidhewitt
left a comment
There was a problem hiding this comment.
Interesting, this makes a ton of sense to do. I wonder, how far do you expect we want to test backwards compatibility in this way?
I see two possible interpretation of your question so I will try to answer both:
|
Introspect crates using old PyO3 versions and check if the output is still correct
Will be useful if we do breaking change to the introspection format