lift undocumented_unsafe_blocks to lint Cargo.toml and top of offending files#6093
Open
davidhewitt wants to merge 5 commits into
Open
lift undocumented_unsafe_blocks to lint Cargo.toml and top of offending files#6093davidhewitt wants to merge 5 commits into
undocumented_unsafe_blocks to lint Cargo.toml and top of offending files#6093davidhewitt wants to merge 5 commits into
Conversation
bschoenmaeckers
approved these changes
Jun 2, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #5487
This moves the
Cargo.tomllevel towarnand applies per-file TODO allows which we can then pick off in individual PRs later.The number of violations in
pyo3-ffiwas low, so I decided to just go ahead and fix those immediately. As a consequence I have removed 4Defaultimplementations for types where I think there is no sensible justification to have a default.