Use NumPy C api to perform conversion to ArrayLike#542
Merged
Conversation
Icxolu
reviewed
Mar 29, 2026
Member
Icxolu
left a comment
Icxolu
left a comment
There was a problem hiding this comment.
Thank you, I have found I problem, otherwise looks good to me.
mattiapenati
force-pushed
the
better-usage-of-c-api
branch
from
fd3a63d to
e5d79d5
Compare
Icxolu
approved these changes
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, the NumPy C API is used to convert from a Python object to ArrayLike. The previous implementation was based on the
numpy.asarrayfunction, this new implementation avoids passing through the interpreter to convert data.The new implementation has been benchmarked and shows no regressions. It is likely slightly faster, though the difference is hard to measure precisely.
Benchmarks have been ported to criterion to remove the dependency on the Rust nightly version.