Skip to content

try build emscripten without flags#568

Open
davidhewitt wants to merge 1 commit intoPyO3:mainfrom
davidhewitt:emscripten-no-args
Open

try build emscripten without flags#568
davidhewitt wants to merge 1 commit intoPyO3:mainfrom
davidhewitt:emscripten-no-args

Conversation

@davidhewitt
Copy link
Member

Possible companion to rust-lang/rust#151704

@davidhewitt
Copy link
Member Author

@hoodmane any idea what happened here? It looks like nightly rust no longer wants to build cdylib crates for wasm, the only recent changes I see to the target spec is your PR to set_output_kind...

@hoodmane
Copy link
Contributor

hoodmane commented Feb 4, 2026

Yeah must be caused by that pr then. I'll look into it, thanks for the ping.

@hoodmane
Copy link
Contributor

hoodmane commented Feb 4, 2026

The flags are no longer necessary but should be harmless. By the way, it should be possible to build with stable rust 1.93.0.

@hoodmane
Copy link
Contributor

hoodmane commented Feb 4, 2026

Okay I'm reproducing this locally. Will look into it and hopefully fix it.

@hoodmane
Copy link
Contributor

hoodmane commented Feb 4, 2026

Okay the problem is related to crt_static. I changed it to be true by default since it is for the Emscripten main module, but it should be false for a dynamic library.

@hoodmane
Copy link
Contributor

hoodmane commented Feb 4, 2026

Okay here's the fix:
rust-lang/rust#152134
Thanks for catching this @davidhewitt !

@hoodmane
Copy link
Contributor

hoodmane commented Feb 4, 2026

And I confirmed that the nox job successfully builds a while when building against the stage1 compiler with my change. (Didn't run the tests but presumably the wheel actually works too...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants