Fix pip install command for test dependencies #1
Conversation
Ensure pytest installs in macOS CI - Require test extras install without ignoring failures
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a51c2b896e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| run: | | ||
| python -m pip install -e . | ||
| python -m pip install -e ".[test]" || true | ||
| python -m pip install -e ".[test]" |
There was a problem hiding this comment.
This now fails the macOS workflow because pyproject.toml defines only dev and docs under [project.optional-dependencies] (no test extra). With || true removed, pip install -e ".[test]" will exit non‑zero on every run, stopping the job before tests. If the intent is to install pytest, this should use the existing .[dev] extra or add a test extra to pyproject.toml.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
This PR removes the || true suffix from the pip install command for test dependencies in the macOS CI workflow, ensuring that failures during test dependency installation will cause the CI step to fail rather than being silently ignored.
Changes:
- Removed
|| truefrom the test dependencies installation command to enforce proper installation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| run: | | ||
| python -m pip install -e . | ||
| python -m pip install -e ".[test]" || true | ||
| python -m pip install -e ".[test]" |
There was a problem hiding this comment.
The extras group "test" does not exist in pyproject.toml. The available extras are "dev", "docs", and "reports". Since the workflow runs pytest, this should likely be changed to ".[dev]" to install pytest and related testing dependencies, matching the pattern used in daily-build.yml workflow.
| python -m pip install -e ".[test]" | |
| python -m pip install -e ".[dev]" |
Ensure pytest installs in macOS CI