Skip to content

Conversation

@Irieo
Copy link
Contributor

@Irieo Irieo commented Nov 17, 2025

Closes #1440

Changes proposed in this Pull Request

This PR fixes two problems related to active/inactive attr handling. First was connected to xarray alignment error when some storage components have active=False due to unfiltered data arrays being combined with filtered variables. Second was connected to spillage variable fail when all StorageUnits are inactive due to empty array issue.

Thanks @SpamAndEgg for spotting these.

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in docs.
  • Unit tests for new features were added (if applicable).
  • A note for the release notes docs/release-notes.md of the upcoming release is included.
  • I consent to the release of this PR's code under the MIT license.

@Irieo Irieo requested a review from lkstrp November 17, 2025 15:01
@lkstrp lkstrp merged commit 1586423 into master Nov 17, 2025
21 of 22 checks passed
@lkstrp lkstrp deleted the fix-activity-mask branch November 17, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Non-active StorageUnit causes bug when writing constraints

3 participants