Fix handling of inactive storage components in constraints/variables #1442
+218
−36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1440
Changes proposed in this Pull Request
This PR fixes two problems related to active/inactive attr handling. First was connected to xarray alignment error when some storage components have active=False due to unfiltered data arrays being combined with filtered variables. Second was connected to spillage variable fail when all StorageUnits are inactive due to empty array issue.
Thanks @SpamAndEgg for spotting these.
Checklist
docs.docs/release-notes.mdof the upcoming release is included.