Merged
Conversation
brunoficoxpress
added a commit
to brunoficoxpress/linopy
that referenced
this pull request
Dec 29, 2025
…date Update Xpress solver API to support new Python interface v9.8
FBumann
added a commit
that referenced
this pull request
Mar 10, 2026
- Add legacy_convention fixture to conftest.py; use it consistently instead of manual try/finally blocks (#1) - Parametrize test_constant_with_extra_dims_broadcasts with convention fixture so it runs under both conventions (#2) - Add missing test_quadratic_add_expr_join_inner to TestJoinParameterLegacy (#3) - Extract shared fixtures into _CoordinateAlignmentFixtures and _ConstraintAlignmentFixtures mixin classes to eliminate fixture duplication between V1/Legacy alignment test classes (#4) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
FBumann
added a commit
that referenced
this pull request
Mar 10, 2026
* Deduplicate convention-specific test files into single files Merge 4 pairs of v1/legacy test files into single files, eliminating ~2600 lines of duplicated test code. Convention-specific alignment tests are kept in separate classes (V1/Legacy) with autouse fixtures, while shared tests run under the module-level v1 convention. - test_typing_legacy.py -> merged into test_typing.py (parametrized) - test_common_legacy.py -> merged into test_common.py (legacy align test) - test_constraints_legacy.py -> merged into test_constraints.py (legacy alignment class) - test_linear_expression_legacy.py -> merged into test_linear_expression.py (legacy alignment + join classes) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Address PR review: consistency, dedup fixtures, missing test - Add legacy_convention fixture to conftest.py; use it consistently instead of manual try/finally blocks (#1) - Parametrize test_constant_with_extra_dims_broadcasts with convention fixture so it runs under both conventions (#2) - Add missing test_quadratic_add_expr_join_inner to TestJoinParameterLegacy (#3) - Extract shared fixtures into _CoordinateAlignmentFixtures and _ConstraintAlignmentFixtures mixin classes to eliminate fixture duplication between V1/Legacy alignment test classes (#4) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.